Add macros to remove old runtime#51967
Closed
RSNara wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72582307 |
Summary: Pull Request resolved: react#51967 This diff adds macros around the legacy architecture core. To compile out the legacy architecture, simply set: -DRCT_FIT_RM_OLD_RUNTIME=1. * RCTBridge: interface kept around * RCTRootView: interface kept around * RCTSurface: interface kept around * RCTModuleData: interface kept around (used by RCTProfile) * RCTProfile: Kept around (doesn't work in bridgeless...) * RCTCxxBridge: interface kept around * c++ bridge: removed * legacy components in core: kept around (for now) ## Details I added comments to each of the #else, and #endif directives. That way, we can more easily codemod this code in the future. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D72582307
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72582307 |
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
added
Stale
Collaborator
|
Closing as this has been merged in fb1a4d7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds macros around the legacy architecture core.
To compile out the legacy architecture, simply set: -DRCT_FIT_RM_OLD_RUNTIME=1.
Details
I added comments to each of the #else, and #endif directives. That way, we can more easily codemod this code in the future.
Changelog: [Internal]
Reviewed By: mdvacca
Differential Revision: D72582307